[uClibc] PATCH: use __libc_gettimeofday instead of gettimeofday

Peter S. Mazinger ps.m at gmx.net
Mon Oct 18 08:51:55 UTC 2004


On Mon, 18 Oct 2004, Joakim Tjernlund wrote:

> > On Mon, 18 Oct 2004, Joakim Tjernlund wrote:
> > 
> > > > Hello!
> > > > 
> > > > Would the attached patch be acceptable (maybe instead of 
> > > > __libc_gettimeofday using __gettimeofday)
> > > > 
> > > > We have some issues, see
> > > > 
> > > > http://bugs.gentoo.org/show_bug.cgi?id=65892
> > > > 
> > > > I think, that the bug could happen on more places in uClibc, not only 
> > > > in ssp.c.
> > > > 
> > > > If it would be acceptable, I would do the same for
> > > > strcpy,strncat,strlen,strncpy,sigaction,kill,sigprocmask
> > > > (see last proposed patch in the bug report)
> > > > 
> > > > Peter
> > > 
> > > Had a look at this patch and I think it is good. This should done to almost all
> > > exported functions in uClibc.
> > > 
> > > Doing so, a program can define its own version of said function if it wants to.
> > > Also, by "hiding"(not in place yet) the internal variant(__libc_xx) you will
> > > remove the relocation of these functions within libc, making the lib
> > > smaller and faster.
> > 
> > glibc uses __ prepended (w/o __libc_), wouldn't it be better to use the 
> > same conventions?
> > 
> > Peter
> 
> glibc uses both and I don't know why or when to use __ or __libc_ or both.

maybe __ for "standard" behaviour, __libc_ for glibc specific behaviour.

Peter

-- 
Peter S. Mazinger <ps dot m at gmx dot net>           ID: 0xA5F059F2
Key fingerprint = 92A4 31E1 56BC 3D5A 2D08  BB6E C389 975E A5F0 59F2




More information about the uClibc mailing list