[uClibc] RE: [uClibc-cvs] uClibc Rules.mak,1.137,1.138

[Erik Andersen]

On Tue Sep 02, 2003 at 10:11:54AM +0200, Peter Kjellerstedt wrote:
> >  ifeq ($(strip $(TARGET_ARCH)),)
> > -TARGET_ARCH:=$(shell $(CC) -dumpmachine | sed -e s'/-.*//' \
> > +TARGET_ARCH=$(shell $(CC) -dumpmachine | sed -e s'/-.*//' \
> >  		-e 's/i.86/i386/' \
> >  		-e 's/sparc.*/sparc/' \
> >  		-e 's/arm.*/arm/g' \
> 
> Any special reason why $(HOST_ARCH) and $(TARGET_ARCH) need
> to be re-evaluated on each use, and thereby causing an
> execution of an external shell each time? It seems very
> inefficient to me.

This change was because I was being stupid.  :-)

> [snip]
>  
> >  ifeq ($(strip $(TARGET_ARCH)),cris)
> > -	CPU_LDFLAGS-$(CONFIG_CRIS):="-mcrislinux"
> > -	CPU_CFLAGS-$(CONFIG_CRIS):="-mlinux"
> > -	PICFLAG:=-fpic
> > +	CPU_LDFLAGS-$(CONFIG_CRIS)+=-mcrislinux
> > +	CPU_CFLAGS-$(CONFIG_CRIS)+=-mlinux
> > +	PICFLAG+=-fpic
> 
> $(PICFLAG) should not be assigned to using += here as this
> assignment is intended to replace the default value of -fPIC,
> not add to it.

Oops.  Sorry.

 -Erik

--
Erik B. Andersen             http://codepoet-consulting.com/
--This message was written using 73% post-consumer electrons--