[Bug 3853] MIPS mmap can not access over 4G file

bugzilla at busybox.net bugzilla at busybox.net
Mon Apr 9 19:46:42 UTC 2012


https://bugs.busybox.net/show_bug.cgi?id=3853

--- Comment #5 from Khem Raj <raj.khem at gmail.com> 2012-04-09 19:46:42 UTC ---
(In reply to comment #4)
> Created attachment 4244 [details]
> mantis 1303 bug info
> 
> your proposed change will undo the previous bug fix.  here's the text of the
> old mantis bug that prompted 22a4424b0b.
> 
> pretty sure the right way to fix this would be to avoid ifdefs and use:
>     return __syscall_mmap2(addr, len, prot, flags, fd,
>                            ((uint64_t)offset >> MMAP2_PAGE_SHIFT));
> 
> this is because we know __off64_t is always going to be a 64bit signed value.

yes that seems to be a better fix. Did you mean to use __off64_t instead of
uint64_t

-- 
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.


More information about the uClibc-cvs mailing list