[git commit nptl] utent.c: fix a few bugs, and shrink a bit
Bernhard Reutner-Fischer
rep.dot.nop at gmail.com
Fri Sep 18 19:04:56 UTC 2009
On Fri, Sep 18, 2009 at 04:07:31PM +0200, Denys Vlasenko wrote:
>
>commit: http://git.uclibc.org/uClibc/commit/?id=2b5155d358188649cc7a6653b5968b514fbfe9cf
>branch: http://git.uclibc.org/uClibc/commit/?id=refs/heads/nptl
>
>bug #1:
> static_fd = -1;
> close(static_fd);
>DOH!
>- return;
>- }
>+ // thus far, {G,S}ETFD only has this single flag,
>+ // and setting it never fails.
>+ //int ret = fcntl(static_fd, F_GETFD, 0);
>+ //if (ret >= 0) {
>+ // ret = fcntl(static_fd, F_SETFD, ret | FD_CLOEXEC);
>+ //}
>+ //if (ret < 0) {
>+ // static_fd = -1;
>+ //}
>+ return;
please, PLEASE use C89 compatible comments or #if 00 them out
so they are easily grep'able.
Using C99 comments is _not_ acceptable, it breaks real bootstraps with
some compilers out there in the wild!
More information about the uClibc-cvs
mailing list