svn commit: trunk/uClibc: ldso/ldso/i386 ldso/ldso/x86_64 libc/str etc...
vda at uclibc.org
vda at uclibc.org
Sun Jul 29 14:45:29 UTC 2007
Author: vda
Date: 2007-07-29 07:45:26 -0700 (Sun, 29 Jul 2007)
New Revision: 19326
Log:
Remove stray code alignment (.align 16 and .align 4 directives)
from i386 and x86_64.
Modified:
trunk/uClibc/ldso/ldso/i386/dl-startup.h
trunk/uClibc/ldso/ldso/i386/resolve.S
trunk/uClibc/ldso/ldso/x86_64/dl-startup.h
trunk/uClibc/ldso/ldso/x86_64/resolve.S
trunk/uClibc/libc/string/sparc/_glibc_inc.h
trunk/uClibc/libc/string/x86_64/_glibc_inc.h
trunk/uClibc/libc/string/x86_64/memset.S
trunk/uClibc/libc/string/x86_64/strcat.S
trunk/uClibc/libc/string/x86_64/strchr.S
trunk/uClibc/libc/string/x86_64/strcpy.S
trunk/uClibc/libc/string/x86_64/strcspn.S
trunk/uClibc/libc/string/x86_64/strlen.S
trunk/uClibc/libc/sysdeps/linux/i386/__longjmp.S
trunk/uClibc/libc/sysdeps/linux/i386/bsd-_setjmp.S
trunk/uClibc/libc/sysdeps/linux/i386/bsd-setjmp.S
trunk/uClibc/libc/sysdeps/linux/i386/mmap64.S
trunk/uClibc/libc/sysdeps/linux/i386/setjmp.S
trunk/uClibc/libc/sysdeps/linux/i386/sigaction.c
trunk/uClibc/libc/sysdeps/linux/i386/syscall.S
trunk/uClibc/libc/sysdeps/linux/i386/vfork.S
trunk/uClibc/libc/sysdeps/linux/sparc/_math_inc.h
trunk/uClibc/libc/sysdeps/linux/x86_64/__longjmp.S
trunk/uClibc/libc/sysdeps/linux/x86_64/bsd-_setjmp.S
trunk/uClibc/libc/sysdeps/linux/x86_64/bsd-setjmp.S
trunk/uClibc/libc/sysdeps/linux/x86_64/clone.S
trunk/uClibc/libc/sysdeps/linux/x86_64/setjmp.S
trunk/uClibc/libc/sysdeps/linux/x86_64/sigaction.c
trunk/uClibc/libc/sysdeps/linux/x86_64/syscall.S
trunk/uClibc/libc/sysdeps/linux/x86_64/vfork.S
Changeset:
Modified: trunk/uClibc/ldso/ldso/i386/dl-startup.h
===================================================================
--- trunk/uClibc/ldso/ldso/i386/dl-startup.h 2007-07-29 14:17:48 UTC (rev 19325)
+++ trunk/uClibc/ldso/ldso/i386/dl-startup.h 2007-07-29 14:45:26 UTC (rev 19326)
@@ -5,7 +5,6 @@
*/
__asm__ (
" .text\n"
- " .align 16\n"
" .globl _start\n"
" .type _start, at function\n"
"_start:\n"
Modified: trunk/uClibc/ldso/ldso/i386/resolve.S
===================================================================
--- trunk/uClibc/ldso/ldso/i386/resolve.S 2007-07-29 14:17:48 UTC (rev 19325)
+++ trunk/uClibc/ldso/ldso/i386/resolve.S 2007-07-29 14:45:26 UTC (rev 19326)
@@ -21,7 +21,6 @@
*/
.text
-.align 4
.globl _dl_linux_resolve
.type _dl_linux_resolve, at function
Modified: trunk/uClibc/ldso/ldso/x86_64/dl-startup.h
===================================================================
--- trunk/uClibc/ldso/ldso/x86_64/dl-startup.h 2007-07-29 14:17:48 UTC (rev 19325)
+++ trunk/uClibc/ldso/ldso/x86_64/dl-startup.h 2007-07-29 14:45:26 UTC (rev 19326)
@@ -8,7 +8,6 @@
*/
__asm__ (
" .text\n"
- " .align 16\n"
" .global _start\n"
" .type _start,%function\n"
"_start:\n"
Modified: trunk/uClibc/ldso/ldso/x86_64/resolve.S
===================================================================
--- trunk/uClibc/ldso/ldso/x86_64/resolve.S 2007-07-29 14:17:48 UTC (rev 19325)
+++ trunk/uClibc/ldso/ldso/x86_64/resolve.S 2007-07-29 14:45:26 UTC (rev 19326)
@@ -26,7 +26,6 @@
.global _dl_linux_resolve
.type _dl_linux_resolve,%function
-.align 16
_dl_linux_resolve:
subq $56,%rsp
Modified: trunk/uClibc/libc/string/sparc/_glibc_inc.h
===================================================================
--- trunk/uClibc/libc/string/sparc/_glibc_inc.h 2007-07-29 14:17:48 UTC (rev 19325)
+++ trunk/uClibc/libc/string/sparc/_glibc_inc.h 2007-07-29 14:45:26 UTC (rev 19326)
@@ -6,6 +6,8 @@
#include <features.h>
#include <bits/wordsize.h>
+/* Is alignment really needed? */
+
#if __WORDSIZE == 32
# define ENTRY_ALIGN 4
#else
Modified: trunk/uClibc/libc/string/x86_64/_glibc_inc.h
===================================================================
--- trunk/uClibc/libc/string/x86_64/_glibc_inc.h 2007-07-29 14:17:48 UTC (rev 19325)
+++ trunk/uClibc/libc/string/x86_64/_glibc_inc.h 2007-07-29 14:45:26 UTC (rev 19326)
@@ -6,15 +6,8 @@
#include <features.h>
#include <bits/wordsize.h>
-#if __WORDSIZE == 32
-# define ENTRY_ALIGN 4
-#else
-# define ENTRY_ALIGN 2
-#endif
-
#define ENTRY(sym) \
.global sym; \
- .align ENTRY_ALIGN; \
.type sym,%function; \
sym:
Modified: trunk/uClibc/libc/string/x86_64/memset.S
===================================================================
--- trunk/uClibc/libc/string/x86_64/memset.S 2007-07-29 14:17:48 UTC (rev 19325)
+++ trunk/uClibc/libc/string/x86_64/memset.S 2007-07-29 14:45:26 UTC (rev 19326)
@@ -71,7 +71,7 @@
jae 11f
.p2align 4
-3: /* Copy 64 bytes. */
+3: /* Fill 64 bytes. */
mov %r8,(%rcx)
mov %r8,0x8(%rcx)
mov %r8,0x10(%rcx)
@@ -84,7 +84,7 @@
dec %rax
jne 3b
-4: /* Copy final bytes. */
+4: /* Fill final bytes. */
and $0x3f,%edx
mov %rdx,%rax
shr $0x3,%rax
@@ -107,7 +107,7 @@
jne 8b
9:
#if BZERO_P
- nop
+ nop /* huh?? */
#else
/* Load result (only if used as memset). */
mov %rdi,%rax /* start address of destination is result */
@@ -115,7 +115,7 @@
retq
.p2align 4
-11: /* Copy 64 bytes without polluting the cache. */
+11: /* Fill 64 bytes without polluting the cache. */
/* We could use movntdq %xmm0,(%rcx) here to further
speed up for large cases but let's not use XMM registers. */
movnti %r8,(%rcx)
Modified: trunk/uClibc/libc/string/x86_64/strcat.S
===================================================================
--- trunk/uClibc/libc/string/x86_64/strcat.S 2007-07-29 14:17:48 UTC (rev 19325)
+++ trunk/uClibc/libc/string/x86_64/strcat.S 2007-07-29 14:45:26 UTC (rev 19326)
@@ -21,6 +21,7 @@
#include "_glibc_inc.h"
+/* Seems to be unrolled too much */
.text
ENTRY (BP_SYM (strcat))
Modified: trunk/uClibc/libc/string/x86_64/strchr.S
===================================================================
--- trunk/uClibc/libc/string/x86_64/strchr.S 2007-07-29 14:17:48 UTC (rev 19325)
+++ trunk/uClibc/libc/string/x86_64/strchr.S 2007-07-29 14:45:26 UTC (rev 19326)
@@ -20,6 +20,7 @@
#include "_glibc_inc.h"
+/* Seems to be unrolled too much */
.text
ENTRY (BP_SYM (strchr))
Modified: trunk/uClibc/libc/string/x86_64/strcpy.S
===================================================================
--- trunk/uClibc/libc/string/x86_64/strcpy.S 2007-07-29 14:17:48 UTC (rev 19325)
+++ trunk/uClibc/libc/string/x86_64/strcpy.S 2007-07-29 14:45:26 UTC (rev 19326)
@@ -20,6 +20,8 @@
#include "_glibc_inc.h"
+/* Seems to be unrolled too much */
+
#ifndef USE_AS_STPCPY
# define STRCPY strcpy
#endif
Modified: trunk/uClibc/libc/string/x86_64/strcspn.S
===================================================================
--- trunk/uClibc/libc/string/x86_64/strcspn.S 2007-07-29 14:17:48 UTC (rev 19325)
+++ trunk/uClibc/libc/string/x86_64/strcspn.S 2007-07-29 14:45:26 UTC (rev 19326)
@@ -25,6 +25,9 @@
#include "_glibc_inc.h"
+/* Seems to be unrolled too much */
+/* (and why testb $0xff, %cl, not testb %cl, %cl?) */
+
/* BEWARE: `#ifdef strcspn' means that strcspn is redefined as `strpbrk' */
#define STRPBRK_P (defined strcspn)
Modified: trunk/uClibc/libc/string/x86_64/strlen.S
===================================================================
--- trunk/uClibc/libc/string/x86_64/strlen.S 2007-07-29 14:17:48 UTC (rev 19325)
+++ trunk/uClibc/libc/string/x86_64/strlen.S 2007-07-29 14:45:26 UTC (rev 19326)
@@ -20,6 +20,7 @@
#include "_glibc_inc.h"
+/* Seems to be unrolled too much */
.text
ENTRY (strlen)
Modified: trunk/uClibc/libc/sysdeps/linux/i386/__longjmp.S
===================================================================
--- trunk/uClibc/libc/sysdeps/linux/i386/__longjmp.S 2007-07-29 14:17:48 UTC (rev 19325)
+++ trunk/uClibc/libc/sysdeps/linux/i386/__longjmp.S 2007-07-29 14:45:26 UTC (rev 19326)
@@ -24,7 +24,6 @@
.global __longjmp
.type __longjmp,%function
-.align 4
__longjmp:
movl 4(%esp), %ecx /* User's jmp_buf in %ecx. */
movl 8(%esp), %eax /* Second argument is return value. */
Modified: trunk/uClibc/libc/sysdeps/linux/i386/bsd-_setjmp.S
===================================================================
--- trunk/uClibc/libc/sysdeps/linux/i386/bsd-_setjmp.S 2007-07-29 14:17:48 UTC (rev 19325)
+++ trunk/uClibc/libc/sysdeps/linux/i386/bsd-_setjmp.S 2007-07-29 14:45:26 UTC (rev 19326)
@@ -27,7 +27,6 @@
.global _setjmp
.type _setjmp,%function
-.align 4
_setjmp:
xorl %eax, %eax
movl 4 (%esp), %edx
Modified: trunk/uClibc/libc/sysdeps/linux/i386/bsd-setjmp.S
===================================================================
--- trunk/uClibc/libc/sysdeps/linux/i386/bsd-setjmp.S 2007-07-29 14:17:48 UTC (rev 19325)
+++ trunk/uClibc/libc/sysdeps/linux/i386/bsd-setjmp.S 2007-07-29 14:45:26 UTC (rev 19326)
@@ -23,7 +23,6 @@
.global setjmp
.type setjmp,%function
-.align 4
setjmp:
movl 4 (%esp), %eax
/* Save registers. */
Modified: trunk/uClibc/libc/sysdeps/linux/i386/mmap64.S
===================================================================
--- trunk/uClibc/libc/sysdeps/linux/i386/mmap64.S 2007-07-29 14:17:48 UTC (rev 19325)
+++ trunk/uClibc/libc/sysdeps/linux/i386/mmap64.S 2007-07-29 14:45:26 UTC (rev 19326)
@@ -40,7 +40,6 @@
.text
.global mmap64
.type mmap64,%function
-.align 1<<4
mmap64:
/* Save registers. */
Modified: trunk/uClibc/libc/sysdeps/linux/i386/setjmp.S
===================================================================
--- trunk/uClibc/libc/sysdeps/linux/i386/setjmp.S 2007-07-29 14:17:48 UTC (rev 19325)
+++ trunk/uClibc/libc/sysdeps/linux/i386/setjmp.S 2007-07-29 14:45:26 UTC (rev 19326)
@@ -24,7 +24,6 @@
.global __sigsetjmp
.type __sigsetjmp,%function
-.align 4
__sigsetjmp:
movl 4 (%esp), %eax
Modified: trunk/uClibc/libc/sysdeps/linux/i386/sigaction.c
===================================================================
--- trunk/uClibc/libc/sysdeps/linux/i386/sigaction.c 2007-07-29 14:17:48 UTC (rev 19325)
+++ trunk/uClibc/libc/sysdeps/linux/i386/sigaction.c 2007-07-29 14:45:26 UTC (rev 19326)
@@ -145,7 +145,6 @@
__asm__ \
( \
".text\n" \
- " .align 16\n" \
"__" #name ":\n" \
" movl $" #syscall ", %eax\n" \
" int $0x80" \
@@ -163,7 +162,6 @@
__asm__ \
( \
".text\n" \
- " .align 8\n" \
"__" #name ":\n" \
" popl %eax\n" \
" movl $" #syscall ", %eax\n" \
Modified: trunk/uClibc/libc/sysdeps/linux/i386/syscall.S
===================================================================
--- trunk/uClibc/libc/sysdeps/linux/i386/syscall.S 2007-07-29 14:17:48 UTC (rev 19325)
+++ trunk/uClibc/libc/sysdeps/linux/i386/syscall.S 2007-07-29 14:45:26 UTC (rev 19326)
@@ -23,7 +23,6 @@
.text
.global syscall
.type syscall,%function
-.align 4
syscall:
pushl %ebp
pushl %edi
Modified: trunk/uClibc/libc/sysdeps/linux/i386/vfork.S
===================================================================
--- trunk/uClibc/libc/sysdeps/linux/i386/vfork.S 2007-07-29 14:17:48 UTC (rev 19325)
+++ trunk/uClibc/libc/sysdeps/linux/i386/vfork.S 2007-07-29 14:45:26 UTC (rev 19326)
@@ -15,7 +15,6 @@
.global __vfork
.hidden __vfork
.type __vfork,%function
-.align 1<<4
__vfork:
popl %ecx
Modified: trunk/uClibc/libc/sysdeps/linux/sparc/_math_inc.h
===================================================================
--- trunk/uClibc/libc/sysdeps/linux/sparc/_math_inc.h 2007-07-29 14:17:48 UTC (rev 19325)
+++ trunk/uClibc/libc/sysdeps/linux/sparc/_math_inc.h 2007-07-29 14:45:26 UTC (rev 19326)
@@ -9,6 +9,8 @@
#define __ASSEMBLY__
#include <asm/traps.h>
+/* Is alignment really needed? */
+
#if __WORDSIZE == 32
# define ENTRY_ALIGN 4
#else
Modified: trunk/uClibc/libc/sysdeps/linux/x86_64/__longjmp.S
===================================================================
--- trunk/uClibc/libc/sysdeps/linux/x86_64/__longjmp.S 2007-07-29 14:17:48 UTC (rev 19325)
+++ trunk/uClibc/libc/sysdeps/linux/x86_64/__longjmp.S 2007-07-29 14:45:26 UTC (rev 19326)
@@ -26,7 +26,6 @@
void __longjmp (__jmp_buf env, int val). */
.global __longjmp
.type __longjmp,%function
-.align 16
__longjmp:
/* Restore registers. */
movq (JB_RBX*8)(%rdi),%rbx
Modified: trunk/uClibc/libc/sysdeps/linux/x86_64/bsd-_setjmp.S
===================================================================
--- trunk/uClibc/libc/sysdeps/linux/x86_64/bsd-_setjmp.S 2007-07-29 14:17:48 UTC (rev 19325)
+++ trunk/uClibc/libc/sysdeps/linux/x86_64/bsd-_setjmp.S 2007-07-29 14:45:26 UTC (rev 19326)
@@ -23,7 +23,6 @@
.global _setjmp
.type _setjmp,%function
-.align 16
_setjmp:
xorq %rsi, %rsi
jmp __sigsetjmp at PLT
Modified: trunk/uClibc/libc/sysdeps/linux/x86_64/bsd-setjmp.S
===================================================================
--- trunk/uClibc/libc/sysdeps/linux/x86_64/bsd-setjmp.S 2007-07-29 14:17:48 UTC (rev 19325)
+++ trunk/uClibc/libc/sysdeps/linux/x86_64/bsd-setjmp.S 2007-07-29 14:45:26 UTC (rev 19326)
@@ -23,7 +23,6 @@
.global setjmp
.type setjmp,%function
-.align 16
setjmp:
movq $1, %rsi
jmp __sigsetjmp at PLT
Modified: trunk/uClibc/libc/sysdeps/linux/x86_64/clone.S
===================================================================
--- trunk/uClibc/libc/sysdeps/linux/x86_64/clone.S 2007-07-29 14:17:48 UTC (rev 19325)
+++ trunk/uClibc/libc/sysdeps/linux/x86_64/clone.S 2007-07-29 14:45:26 UTC (rev 19326)
@@ -53,7 +53,6 @@
.text
.global clone
.type clone,%function
-.align 4
clone:
/* Sanity check arguments. */
movq $-EINVAL,%rax
Modified: trunk/uClibc/libc/sysdeps/linux/x86_64/setjmp.S
===================================================================
--- trunk/uClibc/libc/sysdeps/linux/x86_64/setjmp.S 2007-07-29 14:17:48 UTC (rev 19325)
+++ trunk/uClibc/libc/sysdeps/linux/x86_64/setjmp.S 2007-07-29 14:45:26 UTC (rev 19326)
@@ -23,7 +23,6 @@
.global __sigsetjmp
.type __sigsetjmp,%function
-.align 4
__sigsetjmp:
/* Save registers. */
movq %rbx, (JB_RBX*8)(%rdi)
Modified: trunk/uClibc/libc/sysdeps/linux/x86_64/sigaction.c
===================================================================
--- trunk/uClibc/libc/sysdeps/linux/x86_64/sigaction.c 2007-07-29 14:17:48 UTC (rev 19325)
+++ trunk/uClibc/libc/sysdeps/linux/x86_64/sigaction.c 2007-07-29 14:45:26 UTC (rev 19326)
@@ -138,7 +138,6 @@
asm \
( \
".text\n" \
- ".align 16\n" \
"__" #name ":\n" \
" movq $" #syscall ", %rax\n" \
" syscall\n" \
Modified: trunk/uClibc/libc/sysdeps/linux/x86_64/syscall.S
===================================================================
--- trunk/uClibc/libc/sysdeps/linux/x86_64/syscall.S 2007-07-29 14:17:48 UTC (rev 19325)
+++ trunk/uClibc/libc/sysdeps/linux/x86_64/syscall.S 2007-07-29 14:45:26 UTC (rev 19326)
@@ -26,7 +26,6 @@
.text
.globl syscall
.type syscall,%function
-.align 16
syscall:
movq %rdi, %rax /* Syscall number -> rax. */
movq %rsi, %rdi /* shift arg1 - arg5. */
Modified: trunk/uClibc/libc/sysdeps/linux/x86_64/vfork.S
===================================================================
--- trunk/uClibc/libc/sysdeps/linux/x86_64/vfork.S 2007-07-29 14:17:48 UTC (rev 19325)
+++ trunk/uClibc/libc/sysdeps/linux/x86_64/vfork.S 2007-07-29 14:45:26 UTC (rev 19326)
@@ -32,7 +32,6 @@
.global __vfork
.hidden __vfork
.type __vfork,%function
-.align 16
__vfork:
More information about the uClibc-cvs
mailing list