[PATCH] ifupdown: basic support for bridge_ports

[Joachim Wiberg]

On Tue, Nov 17, 2020 at 11:42, Denys Vlasenko <vda.linux at googlemail.com> wrote:
> On Sat, May 9, 2020 at 4:38 PM Joachim Nilsson <troglobit at gmail.com> wrote:
>> The patch hooks on to the manual method callbacks, adding the bridge
>> interface if it's missing and removing it when taking it down.  Like
>> the bridge-utils-interfaces extension of ifupdown in Debian does.
> Is it compatible with Debian extension?

Yes.  Limited to exact names, no regexp matching for interface names
at the moment, e.g. `bridge_ports regex (eth|port)*`, this is on my
list of things to add next.

There are other bridge_* settings[1] as well, but I wanted to test the
waters first with this, which is very useful on its own.

>> +#include <stdarg.h>
> Unnecessary, libbb.h includes it

Ah, of course.  I can submit a v2 patch if you'd like?


Best regards
 /Joachim

[1]: https://manpages.debian.org/jessie/bridge-utils/bridge-utils-interfaces.5.en.html

-- 
 (@-
 //\  Joachim Wiberg :: https://troglobit.com :: https://github.com/troglobit
 V_/_