[PATCH v2 3/3] touch: remove unneeded GETOPT32 defines

Denys Vlasenko vda.linux at googlemail.com
Mon Apr 12 18:13:39 UTC 2021


Applied all 3 patches. Thank you.

On Sat, Apr 10, 2021 at 12:44 AM Xabier Oneca -- xOneca
<xoneca at gmail.com> wrote:
>
> > Long options handling (getopt32 vs getopt32long) is done in libb.h, no need to
> > care here of the same logic. This cleans the code a bit.
> >
> > Also, --no-create was grouped as a SUSv3 option, where as the short -c was not.
> > Even if it is part of SUS, leave it out as was the short option.
> >
> > v2: Fix for disabled ENABLE_LONG_OPTS. getopt32long does not like
> > IF_FEATURE_xxx() style conditionals... :/
> >
> > Signed-off-by: Xabier Oneca <xoneca at gmail.com>
> > ---
> > coreutils/touch.c | 31 +++++++++++++------------------
> > 1 file changed, 13 insertions(+), 18 deletions(-)
>
> Grr..! GMail botched indentation for review, but the attached patch is correct.
>
> Sorry,
>
> Xabier Oneca_,,_
> _______________________________________________
> busybox mailing list
> busybox at busybox.net
> http://lists.busybox.net/mailman/listinfo/busybox


More information about the busybox mailing list