[PATCH v2 3/3] touch: remove unneeded GETOPT32 defines

Peter D urmum69 at snopyta.org
Fri Apr 9 23:37:17 UTC 2021


> Grr..! GMail botched indentation for review, but the attached patch is
> correct.
git send-email never will :)

I gave it some testing, and everything worked as intended.
I tried the using the following commands:

./busybox touch -d 2000-01-01 -m FILE

This correctly set the access date to
Access: 2021-04-10 00:26:48.000000000 +0100
Modify: 2000-01-01 00:26:57.000000000 +0000

One thing worth noting is that GNU coreutils touch does not include the
minutes and hours at end, when they are not specified in the date.
However, this is not a problem with this patch (if even a problem at
all?).
Whether this behavior is worth emulating is for another thread.

I then tried:

./busybox touch -m FILE and ./busybox touch -a FILE

These both correctly set their respective fields

Lastly, I tried:

./busybox touch -m -a FILE

This also functioned correctly, updating both fields to the same time

So, this all looks good to me.

Peter D.


More information about the busybox mailing list