[PATCH] httpd: code shrink

[Denys Vlasenko]

On Tue, Oct 6, 2020 at 8:36 PM Xabier Oneca -- xOneca <xoneca at gmail.com> wrote:
> Hi Bruno,
> > If I understand correctly:
> >
> > decode_base64() from uuencode.c = bigger one
> > decodeBase64(char *Data) from httpd.c = smaller one
>
> You understood it right. :)
>
> > Assuming they are equivalent (I didn't check), wouldn't it make more sense to:
> > a. Do the check in uuencode.c to see if httpd.c is used and call the httpd one (smaller of the two) in the uudecode/base64 applets?
>
> They are not the same. httpd's decodeBase64() does not have to deal
> with NULL bytes. Any NULL byte will be treated as the end of the
> decoded string.

Actually... httpd.c version is faster and smaller. With some tweaks
it can be made to deal with NULs correctly (and disallow e.g. "==ZZ"
or truncated inputs).