[PATCH 3/5] httpd_indexcgi.c: Simplify CSS

Sergey Ponomarev stokito at gmail.com
Fri Jul 31 19:55:46 UTC 2020


the colors I selected because they are shorter and simpler. We may keep hex
colors instead

On Fri, 31 Jul 2020 at 19:25, Denys Vlasenko <vda.linux at googlemail.com>
wrote:

> On Fri, Jul 10, 2020 at 9:50 PM Sergey Ponomarev <stokito at gmail.com>
> wrote:
> > Divide table to thead, tbody and tfoot as it should be in DOM.
> > Add row hover style.
> > Use short color names.
> >
> > Signed-off-by: Sergey Ponomarev <stokito at gmail.com>
> > ---
> >  networking/httpd_indexcgi.c | 19 ++++++++++++-------
> >  1 file changed, 12 insertions(+), 7 deletions(-)
> >
> > diff --git a/networking/httpd_indexcgi.c b/networking/httpd_indexcgi.c
> > index a94d4983e..b652ba9ff 100644
> > --- a/networking/httpd_indexcgi.c
> > +++ b/networking/httpd_indexcgi.c
> > @@ -55,7 +55,6 @@ httpd_indexcgi.c -o index.cgi
> >  "<style>"                                              \
> >  "table {"                                              \
> >    "width:100%;"                                        \
> > -  "background-color:#fff5ee;"                          \
> >    "border-width:1px;" /* 1px 1px 1px 1px; */           \
> >    "border-spacing:2px;"                                \
> >    "border-style:solid;" /* solid solid solid solid; */ \
> > @@ -76,9 +75,9 @@ httpd_indexcgi.c -o index.cgi
> >    "border-color:black;" /* black black black black; */ \
> >    "white-space:nowrap"                                 \
> >  "}"                                                    \
> > -"tr.hdr { background-color:#eee5de }"                  \
> > -"tr:nth-child(odd) { background-color:#ffffff }"       \
> > -"tr.foot { background-color:#eee5de }"                 \
> > +"thead, tfoot { background-color:olive }"              \
> > +"tbody tr:nth-child(even) { background-color:beige }"  \
> > +"tbody tr:hover {  background-color:ivory }"           \
>
> These colors look not that good to me.
> Can you separate change of colors and change in logic into two patches?
>


-- 
Sergey Ponomarev <https://linkedin.com/in/stokito>, skype:stokito
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/busybox/attachments/20200731/069e52c8/attachment-0001.html>


More information about the busybox mailing list