[PATCH 3/4] httpd: Support caching via 'ETag:' header

Sergey Ponomarev stokito at gmail.com
Sat Jul 11 18:44:50 UTC 2020


Hi Xabier, thanks for the review. Unfortunately I don't have time anymore
so if it is possible just remove the line after merge. As far

On Sat, 11 Jul 2020 at 18:46, Xabier Oneca -- xOneca <xoneca at gmail.com>
wrote:

> Hi Sergey,
>
> Nice patch. Just one comment below:
>
> [...]
> > diff --git a/networking/httpd.c b/networking/httpd.c
> > index 97b61fb77..50a837229 100644
> > --- a/networking/httpd.c
> > +++ b/networking/httpd.c
> > @@ -1699,6 +1725,14 @@ static NOINLINE void send_file_and_exit(const
> char *url, int what)
> >                         send_headers_and_exit(HTTP_NOT_FOUND);
> >                 log_and_exit();
> >         }
> > +#if ENABLE_FEATURE_HTTPD_CACHE
> > +       if (DEBUG)
> > +               bb_perror_msg("Not modified '%s'", url);
> > +       if (modified_since == last_mod) {
> > +               send_headers_and_exit(HTTP_NOT_MODIFIED);
> > +               log_and_exit();
>
> Here this log_and_exit() is redundant. It is already called from
> send_headers_and_exit().
>
> Cheers,
>
> Xabier Oneca_,,_
>


-- 
Sergey Ponomarev <https://linkedin.com/in/stokito>, skype:stokito
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/busybox/attachments/20200711/e1383251/attachment.html>


More information about the busybox mailing list