[PATCH 3/4] lsscsi: code shrink and refactor

Markus Gothe nietzsche at lysator.liu.se
Sat Jul 11 16:13:05 UTC 2020

He shouldn't do anything stupid at all to begin with!
Now go and sit in the corner!


Sent from my BlackBerry - the most secure mobile device

	  Original Message  	

From: xoneca at gmail.com
Sent: July 11, 2020 17:57
To: martin.lewis.x84 at gmail.com
Cc: busybox at busybox.net
Subject: Re: [PATCH 3/4] lsscsi: code shrink and refactor

Hi Martin,

> Remove the use of strou because scsi device types are signed (as seen in the kernel's code).
> Improve the representation of SCSI_DEVICE_LIST.

Maybe you should make those changes in two patches: one that seems
nice and is not attracting much attention (improve SCSI_DEVICE_LIST),
and the other to remove bb_strtou(), that seems a bit controversial.


Xabier Oneca_,,_
busybox mailing list
busybox at busybox.net

More information about the busybox mailing list