[PATCH 1/2] iproute: codeshrink netlink message length check

[Natanael Copa]

On Wed, 13 Nov 2019 18:55:09 +0100
Bernhard Reutner-Fischer <rep.dot.nop at gmail.com> wrote:

> On 12 November 2019 12:04:24 CET, Natanael Copa <ncopa at alpinelinux.org> wrote:
> >reduce size by de-duplicate netlink message length check
> >
> >function                                             old     new  
> >delta
> >check_nlmsg_len                                        -      22    
> >+22
> >print_route                                         1901    1893     
> >-8
> >print_neigh                                         1082    1073     
> >-9
> >iproute_get                                          889     880     
> >-9
> >.rodata                                           139741  139723    
> >-18
> >------------------------------------------------------------------------------
> >(add/remove: 1/0 grow/shrink: 0/4 up/down: 22/-44)            Total:
> >-22
> >bytes
> >   text	   data	    bss	    dec	    hex	filename
> > 876539	  15636	   2080	 894255	  da52f	busybox_old
> > 876517	  15636	   2080	 894233	  da519	busybox_unstripped
> >---
> > networking/libiproute/ip_common.h |  1 +
> > networking/libiproute/ipneigh.c   |  4 +---
> > networking/libiproute/iproute.c   | 14 +++++++++-----
> > 3 files changed, 11 insertions(+), 8 deletions(-)
> >
> >diff --git a/networking/libiproute/ip_common.h
> >b/networking/libiproute/ip_common.h
> >index 40171bed9..9f7f927c7 100644
> >--- a/networking/libiproute/ip_common.h
> >+++ b/networking/libiproute/ip_common.h
> >@@ -30,6 +30,7 @@ int FAST_FUNC do_iplink(char **argv);
> > //int FAST_FUNC do_ipmonitor(char **argv);
> > //int FAST_FUNC do_multiaddr(char **argv);
> > //int FAST_FUNC do_multiroute(char **argv);
> >+int FAST_FUNC check_nlmsg_len(int len);  
> 
> void ?

Yes, of course, it should be void.

Thanks!

-nc