[PATCH] mkdtemp: proper error detection on mktemp
Xabier Oneca -- xOneca
xoneca at gmail.com
Thu Dec 3 22:42:24 UTC 2020
On error, mktemp returns an empty string, not NULL.
Signed-off-by: Xabier Oneca <xoneca at gmail.com>
---
libbb/platform.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libbb/platform.c b/libbb/platform.c
index 03bbb798..187670a8 100644
--- a/libbb/platform.c
+++ b/libbb/platform.c
@@ -107,7 +107,7 @@ void* FAST_FUNC memrchr(const void *s, int c, size_t n)
/* This is now actually part of POSIX.1, but was only added in 2008 */
char* FAST_FUNC mkdtemp(char *template)
{
- if (mktemp(template) == NULL || mkdir(template, 0700) != 0)
+ if (mktemp(template)[0] == '\0' || mkdir(template, 0700) != 0)
return NULL;
return template;
}
--
2.28.0
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-mkdtemp-proper-error-detection-on-mktemp.patch
Type: text/x-patch
Size: 879 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/busybox/attachments/20201203/590ca504/attachment.bin>
More information about the busybox
mailing list