[PATCH] ash: only catch unexpected exceptions in PS1 expansion

[Bastian Bittorf]

On Wed, Jul 31, 2019 at 01:45:23PM +0200, Denys Vlasenko wrote:
> Applied, thanks!
> 
> On Mon, Jul 29, 2019 at 11:00 AM Ron Yorston <rmy at pobox.com> wrote:
> >
> > Commit d1a2fa2a4 (ash: catch error in arithmetic expansion in PS1)
> > catches all exceptions raised by expandarg().  Some exceptions, such as
> > the EXEXIT raised when command expansion is used, are expected:
> >
> >    export PS1='$(echo "$ ")'
> >
> > These should be processed normally or the shell hangs at the prompt.

Maybe i am a "victim" of this patch:
With busybox v1.31.0 on OpenWrt my login "hangs" during the prompt.

Attached is a script, which is sourced during profile.d
You can reproduce the issue by sourcing this script on a system, e.g.

user at box # . /tmp/prompt.sh

After that, i cannot see what i type anymore.

What works is e.g. uptime | logger -s
Also reseting the terminal with 'reset' does not help.

With older busybox-versions, e.g. v1.27.2 it runs without problems.
Sorry that i cannot help more at the moment (e.g. git bisect).

thanks for your work - bye, Bastian Bittorf

-------------- next part --------------
A non-text attachment was scrubbed...
Name: prompt.sh
Type: application/x-sh
Size: 680 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/busybox/attachments/20191019/760e2ed3/attachment.sh>