re [PATCH v3] ash: add process substitution in bash-compatibility mode

Walter Harms wharms at bfs.de
Mon Jan 28 16:22:04 UTC 2019



 			subtype = 0;
 			goto dostr;
+#if !BASH_PROCESS_SUBST
 		case CTLBACKQ:
 			str = "$(...)";
 			goto dostr;
+#else
+		case CTLBACKQ:
+			c = '$';
+			str = "(...)";
+			break;
+		case CTLTOPROC:
+			c = '>';
+			str = "(...)";
+			break;
+		case CTLFROMPROC:
+			c = '<';
+			str = "(...)";
+			break;
+#endif

People are bad at reading NOT-SOMETHING
would you mind to turn the content around ?
would also match the rest of the code 
(found one !BASH_PROCESS_SUBST but with no #else)

just my 2 cents,

re,
 wh


More information about the busybox mailing list