[PATCH] config: PID_FILE_PATH required for FEATURE_CROND_SPECIAL_TIMES

Markus Gothe nietzsche at lysator.liu.se
Tue Aug 27 21:28:57 UTC 2019


Ah, I might have been getting the whole thing wrong. As said I never looked at the original code but did a rain check.

Yeah, creating files out of nowhere is certainly unexpected. Never got that that was the issue, but I can certainly see that giving people headaches.

Recall that I write in generic terms, since I have not used your exact configuration and setup.
Don't get too emotional about what I wrote about upstreaming features; the statement is always valid in the normal case but if you get the premises wrong it doesn't apply ofc. 
Me myself can be kinda harsh since upgrading from 1.20.2 to latest release broke things severly (alright most people doesn't have around 80 000 LOC shell scripts).

Thanks for elaborating the problem it solves.

//M

Sent from my BlackBerry — the most secure mobile device


	  Original Message  



From: james.byrne at origamienergy.com
Sent: 27 August 2019 23:05
To: nietzsche at lysator.liu.se; busybox at busybox.net
Subject: Re: [PATCH] config: PID_FILE_PATH required for FEATURE_CROND_SPECIAL_TIMES


Hi,

On 27/08/2019 19:50, Markus Gothe wrote:
> Having a quick look, I'd say it introduces an unexpected behaviour at
> best.

I'm afraid I don't quite understand your objection. I don't see how this
introduces unexpected behaviour, it's trying to remove the unexpected
behaviour that you currently get if you have FEATURE_CROND_SPECIAL_TIMES
enabled and FEATURE_PIDFILE disabled, where 'crond.reboot' gets created
unexpectedly in the root directory, with no option to put it anywhere else.

> I can in no way personally see any benefits with the patch, since
> most sane users run services supervised and actually want a pidfile.
> The rare exception is if you don't know about "runit" or have really
> small RAM.

You seem to be arguing that no sane user would disable FEATURE_PIDFILE,
which seems a bit of a stretch. I have a perfectly sane embedded system
  configured this way, supervised by runit.

> If a change is only good for a special purpose; then it would
> shouldn't be upstreamed imho.

It's not only for a special purpose, it's for anyone who wants
FEATURE_PIDFILE disabled and FEATURE_CROND_SPECIAL_TIMES enabled.

If I've overlooked something and my change does in fact introduce
unexpected behaviour, please could you explain how so that I can correct it.

Thanks,

James


More information about the busybox mailing list