[PATCH] config: PID_FILE_PATH required for FEATURE_CROND_SPECIAL_TIMES
james.byrne at origamienergy.com
Tue Aug 27 21:05:15 UTC 2019
On 27/08/2019 19:50, Markus Gothe wrote:
> Having a quick look, I'd say it introduces an unexpected behaviour at
I'm afraid I don't quite understand your objection. I don't see how this
introduces unexpected behaviour, it's trying to remove the unexpected
behaviour that you currently get if you have FEATURE_CROND_SPECIAL_TIMES
enabled and FEATURE_PIDFILE disabled, where 'crond.reboot' gets created
unexpectedly in the root directory, with no option to put it anywhere else.
> I can in no way personally see any benefits with the patch, since
> most sane users run services supervised and actually want a pidfile.
> The rare exception is if you don't know about "runit" or have really
> small RAM.
You seem to be arguing that no sane user would disable FEATURE_PIDFILE,
which seems a bit of a stretch. I have a perfectly sane embedded system
configured this way, supervised by runit.
> If a change is only good for a special purpose; then it would
> shouldn't be upstreamed imho.
It's not only for a special purpose, it's for anyone who wants
FEATURE_PIDFILE disabled and FEATURE_CROND_SPECIAL_TIMES enabled.
If I've overlooked something and my change does in fact introduce
unexpected behaviour, please could you explain how so that I can correct it.
More information about the busybox