[PATCH][volume_id][reiserfs structures and etc]
haroon maqsood
maqsood3525 at live.com
Fri Oct 5 11:44:05 UTC 2018
Did not reply to the group, here is the fixed patch.
it was a stupid mistake on my part.
Thanks
Haroon
________________________________
From: Mark Marshall <mark.marshall at omicronenergy.com>
Sent: Friday, October 5, 2018 7:18 AM
To: haroon maqsood; busybox at busybox.net
Subject: Re: [PATCH][volume_id][reiserfs structures and etc]
Hi.
>From a quick scan of the patch, the sscanf seems wrong? You have %ud, and I assume you meant either %u or %d?
int FAST_FUNC volume_id_probe_reiserfs(struct volume_id *id /*,uint64_t off*/)
{
+ len = sscanf(rs->s_v1.s_magic, "ReIsEr%udFs", &ver);
+ if (!len) {
+ if (strcmp(rs->s_v1.s_magic, REISERFS_3_5_SUPER_MAGIC_STRING) != 0)
+ goto x_mgc_str;
Regards,
Mark
________________________________
From: busybox <busybox-bounces at busybox.net> on behalf of haroon maqsood <maqsood3525 at live.com>
Sent: October 05, 2018 02:11
To: busybox at busybox.net
Subject: [PATCH][volume_id][reiserfs structures and etc]
Hi,
PFA a patch to try and streamline the reiserfs structures in use, from volume_id and mkfs_reiser.
i also made some changes to the volume_id probe function for reiserfs, please let me know if you would prefer it in 2 patches.
the structures are used from reiserfsprogs 3.6.27, was there a reason the structures were changed ?, please let me know if am missing something
Thanks
Haroon
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/busybox/attachments/20181005/b1b79190/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-fix-format-specifier.patch
Type: text/x-patch
Size: 17694 bytes
Desc: 0001-fix-format-specifier.patch
URL: <http://lists.busybox.net/pipermail/busybox/attachments/20181005/b1b79190/attachment-0001.bin>
More information about the busybox
mailing list