[PATCH] ash: allow a profile script to be embedded in the binary

Ron Yorston rmy at pobox.com
Sat Nov 3 18:10:41 UTC 2018


Denys,

You wrote:
>As I see it, the purpose of EMBEDDED_SCRIPTS is to have some applets
>written in shell: sometimes that cat be smaller than C code.
>
>What is the purpose of embedded profile script?

That wasn't my view.  As I wrote in my first email:

>The idea is to allow users [to] ship application scripts as part of the
>binary so there's less chance of them getting lost.  It also allows
>them to extend BusyBox without having to write full-blown applets.

The plan was to make it easy for developers to ship customised BusyBox
binaries with application-specific scripts included.  Things that might
not make sense as general-purpose applets.

In that context I think it's reasonable to allow for a profile script.

It's also why, for example, I included the 'embed' directory in
.gitignore:  it was intended for customisation, not for standard applets
implemented as scripts, which already have the 'applets_sh' directory.

Likewise, the embedded scripts have a separate namespace and no mechanism
for installing them.  My view was that applets implemented as scripts
would live in the same namespace as C applets and have their usage
messages and installation directories integrated in the same way.

>From my original email:
>I consider what I've done here orthogonal to the idea of implementing
>actual applets as scripts.  I'd expect the latter to set much higher
>standards in terms of usage documentation and integration.  I'd expect
>script applets to be separately configured at build time and to ensure
>that any other applets required by the script were included.  It'd be
>a whole lot more work to implement.

Ron


More information about the busybox mailing list