[PATCH] nsenter: Rename --network option to --net

Bartosz Gołaszewski bartekgola at gmail.com
Fri May 4 08:22:08 UTC 2018


2018-05-03 14:34 GMT+02:00 Euan Harris <euan.harris at docker.com>:
> In nsenter from util-linux, the long version of the -n option is
> --net=<path>.   BusyBox's version expects --network=<path>, so scripts
> and examples written for util-linux's version cause BusyBox's version
> to exit with the usage message.
>
> Confusingly, until commit 036585a911a5f, the usage message erroneously
> claimed that the long option was indeed called --net; after that commit
> long options are not listed at all.
>
> Signed-off-by: Euan Harris <euan.harris at docker.com>
> ---
>  util-linux/nsenter.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/util-linux/nsenter.c b/util-linux/nsenter.c
> index c6933c8..35439a2 100644
> --- a/util-linux/nsenter.c
> +++ b/util-linux/nsenter.c
> @@ -112,7 +112,7 @@ static const char nsenter_longopts[] ALIGN1 =
>         "user\0"                        Optional_argument       "U"
>         "ipc\0"                         Optional_argument       "i"
>         "uts\0"                         Optional_argument       "u"
> -       "network\0"                     Optional_argument       "n"
> +       "net\0"                         Optional_argument       "n"
>         "pid\0"                         Optional_argument       "p"
>         "mount\0"                       Optional_argument       "m"
>         "target\0"                      Required_argument       "t"
> --
> 2.7.4
>
> _______________________________________________
> busybox mailing list
> busybox at busybox.net
> http://lists.busybox.net/mailman/listinfo/busybox

Thanks for spotting that.

Reviewed-by: Bartosz Golaszewski <bartekgola at gmail.com>


More information about the busybox mailing list