[PATCH] addgroup , adduser series.

[haroon maqsood]

Hi,

i think it might be misunderstanding on my part  about the options.

i was trying to fix this bug https://bugs.busybox.net/show_bug.cgi?id=10981

and restructure the code a bit, but i might be looking at the wrong version of adduser.c (apologies in advance ).

the patch i have so far fixes the bug as i understand it is there (i might be wrong in my understanding)and it removes 110 bytes, if i am understanding the output of make bloatcheck, again you know busybox better then me so you might be able to guide me in this.

regarding the config i know and totally agree with you on this,

it was more from a readability/understanding point of view

Haroon



________________________________
From: busybox <busybox-bounces at busybox.net> on behalf of Tito <farmatito at tiscali.it>
Sent: Sunday, August 5, 2018 6:45 PM
To: busybox at busybox.net
Subject: Re: [PATCH] addgroup , adduser series.

On 05/08/2018 10:51, haroon maqsood wrote:
> Hi
>
> I started working on a patch for adduser utility i.e removing the fixme
> and restructuring the code and implementing options S and D as they are
> currently disabled.

Hi,
S Create a system user/group should be working in both adduser and
addgroup.
D as Disabled or empty password should be working in adduser and
is not needed in addgroup.
Can you explain a little more what you plan to do?

> i though it would make sense to send the first patch that is for
> addgroup, as in my opinion adduser depends on addgroup

Why? Busybox's adduser can use an external addgroup binary
if need be.
>
> and the configs are needed in both places , so they should be in addgroup.

Configs are generated by busybox's config system (e.g. make menuconfig)
and are shared by adduser and addgroup. Why do you need to move them
around?

[*]   Enable sanity check on user/group names in adduser and adgroup
(60000) Last valid uid or gid for adduser and addgroup
(100) First valid system uid or gid for adduser and addgroup
           (999) Last valid system uid or gid for adduser and addgroup


Ciao,
Tito
>
> let me know what you think.
>
> Haroon
>
_______________________________________________
busybox mailing list
busybox at busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
busybox Info Page<http://lists.busybox.net/mailman/listinfo/busybox>
lists.busybox.net
BusyBox combines tiny versions of many common UNIX utilities into a single small executable. It provides minimalist replacements for most of the utilities you usually find in fileutils, shellutils, findutils, textutils, grep, gzip, tar, etc. BusyBox provides a fairly complete POSIX environment for any small or emdedded system.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/busybox/attachments/20180806/8ac7dc08/attachment.html>