[PATCH] testsuite: add test for regression in cat

Natanael Copa ncopa at alpinelinux.org
Fri Apr 27 15:22:14 UTC 2018


Add a couple of tests for a regression introduced with commit 75e90b15
(cat: fix "cat -An" ignoring -n; make numbering go througn all files)

Signed-off-by: Natanael Copa <ncopa at alpinelinux.org>
---

I don't have a fix for the regression yet but I was able to find the
commit which introduces it and made a couple of tests for the testsuite.

The bug causes the testsuite for GNU patch to fail. It took me a while
to figure out that it was a bug in busybox cat and not in GNU patch :)

 testsuite/cat/cat-show-end-of-line             | 3 +++
 testsuite/cat/cat-show-non-printing-characters | 3 +++
 2 files changed, 6 insertions(+)
 create mode 100644 testsuite/cat/cat-show-end-of-line
 create mode 100644 testsuite/cat/cat-show-non-printing-characters

diff --git a/testsuite/cat/cat-show-end-of-line b/testsuite/cat/cat-show-end-of-line
new file mode 100644
index 000000000..46945d4d4
--- /dev/null
+++ b/testsuite/cat/cat-show-end-of-line
@@ -0,0 +1,3 @@
+echo foo | busybox cat -e > foo
+echo 'foo$' > bar
+cmp foo bar
diff --git a/testsuite/cat/cat-show-non-printing-characters b/testsuite/cat/cat-show-non-printing-characters
new file mode 100644
index 000000000..541a8bab8
--- /dev/null
+++ b/testsuite/cat/cat-show-non-printing-characters
@@ -0,0 +1,3 @@
+echo foo | busybox cat -v > foo
+echo foo > bar
+cmp foo bar
-- 
2.17.0



More information about the busybox mailing list