[PATCH 1/2] fix O_CLOEXEC related build problems with kernel versions < 2.6.23
walter harms
wharms at bfs.de
Wed Oct 18 16:27:07 UTC 2017
Am 18.10.2017 18:23, schrieb Eugene Rudoy:
> Hi Xabier,
>
> On Wed, Oct 18, 2017 at 8:52 AM, Xabier Oneca -- xOneca
> <xoneca at gmail.com> wrote:
>>
>> Doesn't xopen always guarantee output_fd will be valid? If so, there's
>> no need for this 'if'.
> you're right, s. [1]. Didn't know that before, thanks for pointing it
> out. v2 of the patch will follow.
>
while you are there ...
please be more verbose "Do not use O_CLOEXEC flags" is nice but why ?
You use a libc that das not support O_CLOEXEC ?, does it cause a bug later ? ....
just a hint,
re,
wh
> Cheers,
> Gene
>
> [1] https://git.busybox.net/busybox/tree/libbb/xfuncs_printf.c?id=ebe6d9d8758d36e03cf39b6587597c67ab778436#n129
> _______________________________________________
> busybox mailing list
> busybox at busybox.net
> http://lists.busybox.net/mailman/listinfo/busybox
>
More information about the busybox
mailing list