[PATCH 7/7] libbb.h: Handle missing HOST_NAME_MAX; ensure MAXFOOLEN agrees with FOO_MAX

Kang-Che Sung explorer09 at gmail.com
Sun Oct 8 11:28:37 UTC 2017


2017年10月8日 18:59,"James Clarke" <jrtc27 at jrtc27.com>寫道:


That's not actually true (any more); util-linux/fdisk_osf.c, whilst
Linux-specific, does use MAXPATHLEN, and networking/traceroute.c uses
MAXHOSTNAMELEN. These could be changed to use {PATH,HOST_NAME}_MAX, but it's
highly likely that a future change will re-introduce a use of one of those
macros and break the build on the Hurd, so why not just define them?


Let's assume that Linux will provide these non-standard macros. You won't
build them in Hurd, so why bother?

The problem is that you can't assume the meanings and usage of two macros
are both the same. You might potentially break more for your "convenience"
definition that's technically unnecessary.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/busybox/attachments/20171008/9c485327/attachment.html>


More information about the busybox mailing list