[PATCH] udhcpc6 ll-address-, options- and release-/renew-fix

tiggersWelt.net (Support) support at tiggerswelt.net
Thu Mar 9 00:15:23 UTC 2017


Thank you both for your feedback!

Am 08.03.2017 um 22:22 schrieb Bernhard Reutner-Fischer:
> On 8 March 2017 21:11:15 CET, Hans Ulli Kroll <ulli.kroll at googlemail.com> wrote:
[...]
>> Please read:
>> Documentation/process/submitting-patches.rst 
>> in the linux source tree.
>>
>> I think busybox is mostly following this. And if you are using git for 
>> create and send patches this is fine, the diff section is out of date.

I'll try to have a look on these guidelines, but it looks quite
time-consuming and we have a very tight project-schedule at the moment.

We don't have a separate git for busybox. It's a subversion repository
keeping a Makefile and a small set of patches for each software-package
we need to build the client-environment together.

Patches are created only on-demand and the one for udhcpc6 is the
biggest one - it is even a single file and was only split up for this
mailinglist.

> Right.
> Furthermore in options use xmalloc and cap the length. Somehow olen computation feels like occurring way too often;

Agreed. The code is working fine but looks kind of horrible. I think we
can do a better job here.

> look at bloat-o-meter output (which you should include in every patch) and try to tweak/rephrase what you want.
> Apart from that it looks like a good thing, please resend?

I'll come back to this, but it may take some time.

-- 
    \\\||///
  \\  - -  //
   (  @ @  )
-oOo--( )--oOo-------------------------------------------------------
 tiggersWelt.net                                 www.tiggersWelt.net
 Inhaber Bernd Holzmüller                       info at tiggerswelt.net
                                            Büro: 07 11 / 550 425-90
 Marktstraße 57                              Fax: 07 11 / 550 425-99
 70372 Stuttgart

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 3310 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://lists.busybox.net/pipermail/busybox/attachments/20170309/0cd82899/attachment.p7s>


More information about the busybox mailing list