[PATCH 0/9] setpriv: dumping and modification of capabilities

Assaf Gordon assafgordon at gmail.com
Thu Jun 29 22:08:10 UTC 2017


Hello Patrick and all,

> On Jun 29, 2017, at 13:34, Patrick Steinhardt <ps at pks.im> wrote:
> 
> I've recently been digging into setpriv from util-linux and
> implemented ambient capabilities.
[...]
> I first want to gauge interest in increasing the scope of setpriv
> with these patches. If you as a project are interested, I'll
> implement additional missing bits such as changing users and
> groups, making it complete for at least my own use cases.

This all looks good and useful to me (but i'm not a busybox developer).

One small suggestion: perhaps consider making each sub-part optional
at compilation time? so that if someone doesn't need "--dump" or doesn't
need "--cap" or "--inh-caps", they can build a smaller binary without them ?

Also,
Thanks for spotting and fixing the getopt bug in my previous code.

regards,
 - assaf




More information about the busybox mailing list