[PATCH] ash: avoid GLIBC'ism %m

Kang-Che Sung explorer09 at gmail.com
Sun Jul 23 02:03:19 UTC 2017


On Sun, Jul 23, 2017 at 4:33 AM, Michael Conrad <mconrad at intellitree.com> wrote:
> On 7/22/2017 2:56 PM, Johannes Schindelin wrote:
>>
>> No, not every libc. I would not have spent the time and effort to develop
>> the patch, contribute it, rework it and contribute a second iteration if
>> it was not for a good reason now, would I.
>>
>
> I believe his point is that your patch adds size to busybox which is
> unneeded for most users.  (btw, it's recommended to post bloatcheck numbers
> with a patch.  If you show a small number from bloatcheck then there is less
> to argue about)
>
> Which libc are you using?  Do you think %m support could be checked with an
> ifdef?
>

How about wrapping the printf("%m") uses within the __GNU_LIBRARY__ macro?
It seems that %m support has been there from the beginning of glibc.


More information about the busybox mailing list