[PATCH] dpkg: fix CONFIG_FEATURE_CLEAN_UP handling

Peter Korsgaard peter at korsgaard.com
Wed Jul 5 09:53:58 UTC 2017


dpkg moved to away from dynamically allocating the hashtables in commit
c87339d584 (dpkg: trivial code shrinkage, and redo G trick correctly) almost
ten years ago, but the cleanup code was never adjusted to match.

Glibc loudly complains about this:

*** Error in `dpkg': free(): invalid pointer: 0x0000007fac3478c0 ***

Signed-off-by: Peter Korsgaard <peter at korsgaard.com>
---
 archival/dpkg.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/archival/dpkg.c b/archival/dpkg.c
index 1cd45eda4..da3b0864e 100644
--- a/archival/dpkg.c
+++ b/archival/dpkg.c
@@ -1938,10 +1938,6 @@ int dpkg_main(int argc UNUSED_PARAM, char **argv)
 		for (i = 0; i < STATUS_HASH_PRIME; i++) {
 			free(status_hashtable[i]);
 		}
-
-		free(status_hashtable);
-		free(package_hashtable);
-		free(name_hashtable);
 	}
 
 	return EXIT_SUCCESS;
-- 
2.11.0



More information about the busybox mailing list