bugs in a couple scripts

[Kang-Che Sung]

On Sun, Jan 22, 2017 at 6:56 AM, J <j at dawnrazor.net> wrote:
> Hello mailing list,
>
> i found (the hard way) that scripts/gen_build_files.sh is making unsafe
> assumptions about the nature of /bin/sh; it appears to be presuming that
> it's bash or dash or something:
> --
>   GEN     runit/Kbuild
> /usr/src/install/busybox-1.26.2/scripts/gen_build_files.sh[23]: local: not
> found [No such file or directory]
>   GEN     runit/Config.in
>   HOSTCC  scripts/basic/fixdep
> /usr/src/install/busybox-1.26.2/scripts/gen_build_files.sh[23]: local: not
> found [No such file or directory]
> sed: can't read : No such file or directory
> sed: can't read : No such file or directory
>   GEN
> mv: cannot rename .tmp to : No such file or directory
> /usr/src/install/busybox-1.26.2/scripts/gen_build_files.sh[23]: local: not
> found [No such file or directory]
> sed: can't read : No such file or directory
>   HOSTCC  scripts/basic/docproc
>   HOSTCC  scripts/basic/split-include
> sed: can't read : No such file or directory
>   GEN
> mv: cannot rename .tmp to : No such file or directory
> /usr/src/install/busybox-1.26.2/scripts/gen_build_files.sh[23]: local: not
> found [No such file or directory]
> /usr/src/install/busybox-1.26.2/scripts/gen_build_files.sh[23]: local: not
> found [No such file or directory]
> --
>
> and so on. attached is a patch which fixes this script and thus allows
> busybox to build. while i was in scripts/ i also noticed that the "trylink"
> script is making the same wrong assumption, so i went ahead and patched it
> as well to be safe, and i've attached that also.
>

Your attached scripts.trylink.diff has bugs. It seems that you just found-and-
replaced the variables without verifying the script further.

It should give you "cc_r: command not found" and "lig_r: command not found".
I hope you know where I'm talking about.