bugs in a couple scripts

J j at dawnrazor.net
Sat Jan 21 22:56:22 UTC 2017


Hello mailing list,

i found (the hard way) that scripts/gen_build_files.sh is making  
unsafe assumptions about the nature of /bin/sh; it appears to be  
presuming that it's bash or dash or something:
--
   GEN     runit/Kbuild
/usr/src/install/busybox-1.26.2/scripts/gen_build_files.sh[23]: local:  
not found [No such file or directory]
   GEN     runit/Config.in
   HOSTCC  scripts/basic/fixdep
/usr/src/install/busybox-1.26.2/scripts/gen_build_files.sh[23]: local:  
not found [No such file or directory]
sed: can't read : No such file or directory
sed: can't read : No such file or directory
   GEN
mv: cannot rename .tmp to : No such file or directory
/usr/src/install/busybox-1.26.2/scripts/gen_build_files.sh[23]: local:  
not found [No such file or directory]
sed: can't read : No such file or directory
   HOSTCC  scripts/basic/docproc
   HOSTCC  scripts/basic/split-include
sed: can't read : No such file or directory
   GEN
mv: cannot rename .tmp to : No such file or directory
/usr/src/install/busybox-1.26.2/scripts/gen_build_files.sh[23]: local:  
not found [No such file or directory]
/usr/src/install/busybox-1.26.2/scripts/gen_build_files.sh[23]: local:  
not found [No such file or directory]
--

and so on. attached is a patch which fixes this script and thus allows  
busybox to build. while i was in scripts/ i also noticed that the  
"trylink" script is making the same wrong assumption, so i went ahead  
and patched it as well to be safe, and i've attached that also.

thanks.
J
-------------- next part --------------
A non-text attachment was scrubbed...
Name: scripts.gen_build_files.sh.diff
Type: text/diff
Size: 1016 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/busybox/attachments/20170121/7bf3a5b9/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: scripts.trylink.diff
Type: text/diff
Size: 1737 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/busybox/attachments/20170121/7bf3a5b9/attachment-0001.bin>


More information about the busybox mailing list