[PATCH] Fix ash "kill %1" not working if CONFIG_ASH is disabled

Kang-Che Sung explorer09 at gmail.com
Mon Jan 9 02:11:42 UTC 2017


On Mon, Jan 9, 2017 at 10:03 AM, Kang-Che Sung <explorer09 at gmail.com> wrote:
> On Sun, Jan 8, 2017 at 7:40 PM, Xabier Oneca  --  xOneca
> <xoneca at gmail.com> wrote:
>> Hello Kang-Che,
>>
>>> diff --git a/procps/kill.c b/procps/kill.c
>>> index 57a33bcaa..198c78de0 100644
>>> --- a/procps/kill.c
>>> +++ b/procps/kill.c
>>> @@ -285,10 +285,10 @@ int kill_main(int argc UNUSED_PARAM, char **argv)
>>>
>>>   /* Looks like they want to do a kill. Do that */
>>>   while (arg) {
>>> -#if ENABLE_ASH || ENABLE_HUSH
>>> +#if ENABLE_ASH || ENABLE_SH_IS_ASH || ENABLE_BASH_IS_ASH
>>
>> You dropped ENABLE_HUSH here. Is it intentional?
>>
> hush doesn't have a built-in kill command. Yes, it's intentional.

Correction. Well, hush _used to_ not have a built-in kill command, but
it seems that Denys Vlasenko tried to implement it recently:
https://git.busybox.net/busybox/commit/?id=1125d7d6801940a5218b74c8fd46f1eaa2e4de39
And so my patch got modified by him before getting merged.


More information about the busybox mailing list