[PATCH] appletlib: avoid warning on unused function ingroup

Cristian Ionescu-Idbohrn cristian.ionescu-idbohrn at axis.com
Mon Jan 2 10:17:09 UTC 2017


libbb/appletlib.c:558:12: warning: 'ingroup' defined but
                                   not used [-Wunused-function]
 static int ingroup(uid_t u, gid_t g)
            ^~~~~~~

That function is used only if FEATURE_SUID_CONFIG is also enabled.

Signed-off-by: Cristian Ionescu-Idbohrn <cristian.ionescu-idbohrn at axis.com>
---
 libbb/appletlib.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/libbb/appletlib.c b/libbb/appletlib.c
index ee8b4ec14..805cd3ae6 100644
--- a/libbb/appletlib.c
+++ b/libbb/appletlib.c
@@ -554,6 +554,7 @@ static inline void parse_config_file(void)
 
 
 # if ENABLE_FEATURE_SUID && NUM_APPLETS > 0
+#  if ENABLE_FEATURE_SUID_CONFIG
 /* check if u is member of group g */
 static int ingroup(uid_t u, gid_t g)
 {
@@ -568,6 +569,7 @@ static int ingroup(uid_t u, gid_t g)
 	}
 	return 0;
 }
+#  endif
 
 static void check_suid(int applet_no)
 {
-- 
2.11.0



More information about the busybox mailing list