[PATCH] strings implement -t radix v2

Chris Renshaw osm0sis at outlook.com
Mon Oct 17 16:29:30 UTC 2016


>On 10/15/2016 03:22 PM, Tito wrote:
>> Hi,
>> the attached patch implements -t radix option
>> for strings program and fixes the help text
>> for -o option.
>> During the little testing I've done the output
>> seems the same as binutils string.
>>
>> Ciao,
>> Tito
>>
>Hi,
>minor code cleanup, no changes
>better readability.
>
>Ciao,
>Tito
> 
>_______________________________________________
>
>Hi,
>I could take a look at it if you are not in a hurry
>because for the next 2 weeks I am in vacation and
>I am a slow-coder due to lack of training.
>
>Ciao,
>Tito
>
>_______________________________________________
>
>Hi,
>I couldn't resist so I wrote and sent a patch to implement
>-t radix option to the list.
>Needs a little more testing, maybe you could take
>a look at it.
>
>Ciao,
>Tito
>
>PS.: improvements and hints are welcome.

Looks really good! Thank you for finding the time; I was completely lost when trying to figure out how to alter the argv handling. :)

I had to reformat the .patch file to the "email patch" style using git so that it would apply with the `patch` command. I've attached it so Denys or whoever can merge it more easily.

Working well. I'll look forward to seeing it in the next feature version.

Cheers,
Chris
-------------- next part --------------
A non-text attachment was scrubbed...
Name: strings_v2-git.patch
Type: application/octet-stream
Size: 2905 bytes
Desc: strings_v2-git.patch
URL: <http://lists.busybox.net/pipermail/busybox/attachments/20161017/7dbabea5/attachment.obj>


More information about the busybox mailing list