[PATCH v2 2/4] unshare: new applet

Bartosz Gołaszewski bartekgola at gmail.com
Mon Mar 14 17:09:16 UTC 2016


2016-03-14 15:11 GMT+01:00 Mike Frysinger <vapier at gentoo.org>:
> On 14 Mar 2016 11:08, Bartosz Gołaszewski wrote:
>> 2016-03-11 18:24 GMT+01:00 Mike Frysinger <vapier at gentoo.org>:
>> > On 11 Mar 2016 18:10, Bartosz Golaszewski wrote:
>> >> +int unshare_main(int argc UNUSED_PARAM, char **argv)
>> >> +{
>> >> +     static struct namespace ns_list[] = {
>> >
>> > const ?
>> >
>>
>> Nope, we're using char *path to store the mount points.
>
> that's kind of a big chunk of data to blend read-only & writable
> data in.  can't you create a parallel array just for the writable
> data and use the indices you have now to index it ?
> -mike

Please take a look at v4. I also tried making struct namespace_descr
common for both applets but with the option bits that have different
values and need manual assignment it turned out the code actually got
bigger, so I dropped it.

-- 
Best regards,
Bartosz Golaszewski


More information about the busybox mailing list