[PATCH V2]networking: Allow dot at the end of the domain name in dhcp response

[Denys Vlasenko]

Applied, thanks

On Thu, Feb 11, 2016 at 6:24 AM, Rich Felker <dalias at libc.org> wrote:
> On Thu, Feb 11, 2016 at 05:59:39AM +0100, Denys Vlasenko wrote:
>> On Tue, Feb 9, 2016 at 6:23 PM, Balaji Punnuru <balaji.punnuru at gmail.com> wrote:
>> > When a dhcp server responds with a domain name that ends with a ".",
>> > domain name validation is failing which leads to populating domain bad in
>> > resolv.conf
>> >
>> > Domain name ending with . is a valid syntax according RFC-1034.
>> >
>> > The Patch fixes the domain name validation which ends with "."
>>
>> Well, this may be technically allowed, but wouldn't you think that
>> such DHCP response is definitely odd, and it's better to know about it?
>
> Maybe a log message for the oddity, but it should not result in active
> misconfiguration. Ending dns names with a dot is valid and IIRC
> historically this practice was used to indicate that the name is
> anchored to the dns root rather than possibly being interpreted
> relative to some domain. The standard APIs for lookups all accept
> names ending with a dot, and this should suppress search domains.
>
> Rich