[PATCH] init: allow to preserve init's command-line

Nicolas CARRIER carrier.nicolas0 at gmail.com
Thu Feb 11 07:11:07 UTC 2016


Hello,
is there still any concern regarding this patch ? Is it possible to
integrate it ?

For in formation, it has been integrated in the busybox version we use
at Parrot and is used with no known problem so far.

Thank you.

2016-02-04 12:42 GMT+01:00 Nicolas CARRIER <carrier.nicolas0 at gmail.com>:
> Please find attached the new version implementing
> FEATURE_INIT_MODIFY_CMDLINE, defaulting to "y".
>
> 2016-02-04 8:12 GMT+01:00 Nicolas CARRIER <carrier.nicolas0 at gmail.com>:
>> OK, I will send the new patch ASAP
>>
>> Le 3 févr. 2016 18:39, "Mike Frysinger" <vapier at gentoo.org> a écrit :
>>>
>>> On 03 Feb 2016 12:45, Daniel Thompson wrote:
>>> > On 03/02/16 12:29, Nicolas CARRIER wrote:
>>> > > Honestly, I hesitated to propose the inverse feature.
>>> > > I think the key point is : what we consider "normal" behavior ?
>>> > > I tend to consider it's "keep your arguments as they were passed to
>>> > > you", but I felt there was more people favoring the "do as you've
>>> > > always done".
>>> >
>>> > Defaults are enough to handle "normal" behavior; inverting the
>>> > definition of a feature isn't helpful.
>>> >
>>> > It is far better (and more intuitive) if: feature off -> smaller code
>>>
>>> naming wise, FEATURE_INIT_MODIFY_CMDLINE is fine.  the "default" value
>>> can be easily used to set the state regardless of naming and inverted.
>>>
>>> i have no strong opinion either way as to the default.  disabling the
>>> munging by default does yield smaller code.
>>> -mike


More information about the busybox mailing list