ip route add bug in 1.25.0

Ron Yorston rmy at pobox.com
Fri Aug 5 18:02:39 UTC 2016


Timo Teras wrote:
>Sounds like it's assuming the structure was previously initialized
>to all zeroes, and it's intended as a micro optimization to avoid
>writing zeroes again if the constant is zero.

Yes, that makes sense.

>Should probably just delete all those. Properly optimizing compiler
>would handle that automatically.

Apparently not, it does save a few bytes.  req.r.rtm_scope has already
been initialised to a non-zero value, though, so that one should come
out.  I'll put together a patch.

Ron


More information about the busybox mailing list