[PATCH] umount: always use umount2 syscall with specified flags

Xabier Oneca -- xOneca xoneca at gmail.com
Sat Oct 17 10:51:16 UTC 2015


Hello Denys,

2015-10-13 17:22 GMT+02:00 Denys Vlasenko <vda.linux at googlemail.com>:
> I committed several changes which adopt kernel-style BUILD_BUG_ON:
>
> #define BUILD_BUG_ON(condition) ((void)sizeof(char[1 - 2*!!(condition)]))
>
> Need some analogue for declaration-level check.
> BUILD_BUG_ON would not work here:
>
> typedef struct svstatus_t {
>         uint64_t time_be64 PACKED;
>         uint32_t time_nsec_be32 PACKED;
>         uint32_t pid_le32 PACKED;
>         uint8_t  paused;
>         uint8_t  want; /* 'u' or 'd' */
>         uint8_t  got_term;
>         uint8_t  run_or_finish;
> } svstatus_t;
> struct ERR_svstatus_must_be_20_bytes {
>         char ERR_svstatus_must_be_20_bytes[sizeof(svstatus_t) == 20 ? 1 : -1];
> };

Whoa! I've seen a lot of work in this topic! Nice work!

Cheers,

Xabier Oneca_,,_


More information about the busybox mailing list