[PATCH v2] nandwrite: implement -n (read/write without ecc)

Aaro Koskinen aaro.koskinen at iki.fi
Mon Nov 16 20:14:05 UTC 2015


Hi,

On Mon, Nov 16, 2015 at 06:20:51AM +0200, Baruch Siach wrote:
> On Mon, Nov 16, 2015 at 02:10:53AM +0200, Aaro Koskinen wrote:
> > @@ -144,6 +147,9 @@ int nandwrite_main(int argc UNUSED_PARAM, char **argv)
> >  	fd = xopen(argv[0], IS_NANDWRITE ? O_RDWR : O_RDONLY);
> >  	xioctl(fd, MEMGETINFO, &meminfo);
> >  
> > +	if ((opts & OPT_n) && ioctl(fd, MTDFILEMODE, MTD_FILE_MODE_RAW))
> > +		bb_simple_perror_msg_and_die("MTDFILEMODE");
> 
> Why not just use xioctl instead of open coding it?

xioctl() takes pointer argument.

A.


More information about the busybox mailing list