AW: [PATCH 5/5] Bionic lacks transparent LFS migrations; provide a workaround

[dietmar.schindler at manroland-web.com]

> Von: Denys Vlasenko [mailto:vda.linux at googlemail.com]
> Gesendet: Sonntag, 3. Mai 2015 18:48
>
> On Tue, Apr 28, 2015 at 8:36 AM,  <dietmar.schindler at manroland-web.com> wrote:
> > Whose policy is that which caters to a certain compiler option's inept warnings? "What are
> the goals of Busybox?" (http://www.busybox.net/FAQ.html#goals) says: "We also want to have
> the simplest and cleanest implementation we can manage..." - I wouldn't say that
> >
> > #if defined(__BIONIC__) && defined(_FILE_OFFSET_BITS) && _FILE_OFFSET_BITS == 64
> >
> > is as simple and clean as
> >
> > #if defined(__BIONIC__) && _FILE_OFFSET_BITS == 64
>
> But the former lets compiler catch a typo...

How's that? The way I see it, the former provides even more opportunities of making uncatched typos, e. g.

#if defined(__BIONIC__) && defined(__FILE_OFFSET_BITS) && _FILE_OFFSET_BITS == 64
--
Best regards,
Dietmar Schindler
________________________________
manroland web systems GmbH -- Managing Director: Joern Gosse
Registered Office: Augsburg -- Trade Register: AG Augsburg -- HRB-No.: 26816 -- VAT: DE281389840

Confidentiality note:
This eMail and any files transmitted with it are confidential and intended solely for the use of the individual or entity to whom they are addressed. If you are not the intended recipient, you are hereby notified that any use or dissemination of this communication is strictly prohibited. If you have received this eMail in error, then please delete this eMail.

! Please consider your environmental responsibility before printing this eMail !
________________________________