[PATCH] zcip: fix link-local IP conflict detection

[Vladislav Grishenko]

Hi Denys,

Applied commit "a4d564ad zcip: fix link-local IP conflict detection" has
introduced wrong
comparison of source IP with our/choosen IP. This again leads to a new IP
being repacked
on every incoming ARP packet.
Please refer patch against current git attached.

Best Regards, Vladislav Grishenko

> -----Original Message-----
> From: busybox-bounces at busybox.net [mailto:busybox-
> bounces at busybox.net] On Behalf Of Denys Vlasenko
> Sent: Sunday, July 20, 2014 6:03 PM
> To: Ben Shelton
> Cc: busybox; Ken Sharp
> Subject: Re: [PATCH] zcip: fix link-local IP conflict detection
> 
> On Thu, Jul 17, 2014 at 6:34 PM, Ben Shelton <ben.shelton at ni.com> wrote:
> > From: Ken Sharp <ken.sharp at ni.com>
> >
> > During link-local IP resolution, if a regular ARP request is received
> > during the ARP probe period, it will incorrectly cause a target IP
> > conflict.  This then leads to a new IP being picked unnecessarily.
> >
> > Per RFC 3927, section 2.2.1, we should flag a target IP conflict only
> > if the source IP is null, the target IP matches our IP, and the source
> > hw addr does not match our hw addr.
> >
> > Signed-off-by: Ken Sharp <ken.sharp at ni.com>
> > Signed-off-by: Ben Shelton <ben.shelton at ni.com>
> > ---
> >
> > Note that we reproduced the issue and tested the fix on an ARM
> > A9-based board as follows:
> >
> > - Connect two machines via a crossover cable or on a network with no
> DHCP
> >   server available.
> > - Continuously ping the machine running busybox from the other
> > - Reboot the busybox machine (the one being pinged)
> > - When the busybox machine comes back up it will have a different IP
> >   address because of the incorrect target IP conflict
> >
> 
> 
> Applied, thanks!
> _______________________________________________
> busybox mailing list
> busybox at busybox.net
> http://lists.busybox.net/mailman/listinfo/busybox
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-zcip-fix-wrong-comparison-of-source-IP-with-our-IP.patch
Type: application/octet-stream
Size: 1040 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/busybox/attachments/20150319/60007ab8/attachment-0001.obj>