[PATCH v2] i2cdetect: use break instead of goto in list_i2c_busses_and_exit()

Bartosz Gołaszewski bartekgola at gmail.com
Mon Jun 8 11:49:02 UTC 2015


2015-06-07 18:08 GMT+02:00 Denys Vlasenko <vda.linux at googlemail.com>:
> Applied all five patches, thanks!
>
> On Fri, Jun 5, 2015 at 10:47 AM, Bartosz Golaszewski
> <bartekgola at gmail.com> wrote:
>> Since there are no more statements in the if block after the while loop
>> in list_i2c_busses_and_exit(), there's no need for a goto.
>>
>> Signed-off-by: Bartosz Golaszewski <bartekgola at gmail.com>
>> ---
>> NOTES: fixed two typos in the commit message.

Hi Denys,

you applied the previous version of patch [5/5] - the one with typos
in the commit message. I don't know what the busybox policy is on
force-pushing to mainline git, but saying 'there are now more
statements' instead of 'there are no more statements' can be
confusing. ;)

Best regards,
Bartosz Golaszewski


More information about the busybox mailing list