[PATCH] udhcpc: dns labels can actually start with a number

[Denys Vlasenko]

Applied, thanks!

On Tue, Jul 28, 2015 at 7:35 AM, Arthur Gautier <baloo at gandi.net> wrote:
> While RFC1035 recommends a label not to start with a number, there is
> actually no such limitation in dns. One may buy a domain name like
> 0x1.net and use it.
>
> This commit remove this check and allow a user to use such domains.
>
> Signed-off-by: Arthur Gautier <baloo at gandi.net>
> ---
>  networking/udhcp/dhcpc.c | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/networking/udhcp/dhcpc.c b/networking/udhcp/dhcpc.c
> index 9d3d1a31caf9..811a1a1eebe5 100644
> --- a/networking/udhcp/dhcpc.c
> +++ b/networking/udhcp/dhcpc.c
> @@ -156,10 +156,6 @@ static const char *valid_domain_label(const char *label)
>         for (;;) {
>                 ch = *label;
>                 if ((ch|0x20) < 'a' || (ch|0x20) > 'z') {
> -                       if (pos == 0) {
> -                               /* label must begin with letter */
> -                               return NULL;
> -                       }
>                         if (ch < '0' || ch > '9') {
>                                 if (ch == '\0' || ch == '.')
>                                         return label;
> --
> 2.1.4
>
> _______________________________________________
> busybox mailing list
> busybox at busybox.net
> http://lists.busybox.net/mailman/listinfo/busybox