1.23.0 FreeBSD build fails: 1 showstopper mempcpy(), 1 sendfile() incompat.
Matthias Andree
mandree at FreeBSD.org
Wed Jan 28 21:50:43 UTC 2015
Am 25.01.2015 um 22:10 schrieb Denys Vlasenko:
> On Mon, Jan 19, 2015 at 12:47 PM, Bartosz Gołaszewski
> <bartekgola at gmail.com> wrote:
>> 2015-01-18 10:31 GMT+01:00 Matthias Andree <mandree at freebsd.org>:
>>>
>>> That was the minor part because I can disable it by build configuration.
>>>
>>> What about mempcpy()? That is a showstopper.
>>
>> Please try the attached patch. I didn't try to compile it on a FreeBSD
>> system, but if it works for you we can ask Denys to merge it.
>
> I'm applying a version which uses HAVE_MEMPCPY style,
> consistent with other compat crutches we have.
> But for now, I'm disabling it:
>
> #if defined(__FreeBSD__)
> //# undef HAVE_MEMPCPY - not yet confirmed
> # undef HAVE_CLEARENV
>
>
> Matthias, please get current git, uncomment this line,
> and confirm that it builds for you. Let me know the version
> of FreeBSD which needs it (newer ones may grow their own
> mempcpy(), we need to be ready for that).
That works.
Additionally:
1. You need to add #include <string.h> to obtain memcpy() in the
replacement, and
2. also add -fno-builtin-mempcpy to the compiler flags to quench
-Wshadow warnings that the mempcpy() shadows a GCC built-in.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: OpenPGP digital signature
URL: <http://lists.busybox.net/pipermail/busybox/attachments/20150128/1746b7de/attachment.asc>
More information about the busybox
mailing list