[RFC/PATCH 01/10] unit-tests: remove unnecesary field from struct bbunit_listelem

Bartosz Golaszewski bartekgola at gmail.com
Thu Aug 13 13:57:21 UTC 2015


In the initial submission struct bbunit_listelem was manipulated by
custom list functions implemented in bbunit.c. Since the tests are now
added to the list by llist_add_to_end(), which allocates the llist_t
objects behind the scenes, there's no need for the *next field.

function                                             old     new   delta
unit_main                                            142     141      -1
bbunit_strrstr_elem                                   24      16      -8
bbunit_obscure_weak_pass_elem                         24      16      -8
bbunit_obscure_strong_pass_elem                       24      16      -8
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 0/4 up/down: 0/-25)             Total: -25 bytes

Signed-off-by: Bartosz Golaszewski <bartekgola at gmail.com>
---
 include/libbb.h | 1 -
 libbb/bbunit.c  | 1 -
 2 files changed, 2 deletions(-)

diff --git a/include/libbb.h b/include/libbb.h
index 54d01b7..136d4fd 100644
--- a/include/libbb.h
+++ b/include/libbb.h
@@ -1983,7 +1983,6 @@ static ALWAYS_INLINE unsigned char bb_ascii_tolower(unsigned char a)
 typedef void (*bbunit_testfunc)(void);
 
 struct bbunit_listelem {
-	struct bbunit_listelem* next;
 	const char* name;
 	bbunit_testfunc testfunc;
 };
diff --git a/libbb/bbunit.c b/libbb/bbunit.c
index 4c692d5..66a7df9 100644
--- a/libbb/bbunit.c
+++ b/libbb/bbunit.c
@@ -71,7 +71,6 @@ int unit_main(int argc UNUSED_PARAM, char **argv UNUSED_PARAM)
 			tests_failed++;
 		}
 		tests_run++;
-		el = el->next;
 	}
 
 #if WANT_TIMING
-- 
2.1.4



More information about the busybox mailing list