[Bug: Busybox 1.22.1] false return 0 instead of 1 with '--help' switch.

[Xabier Oneca -- xOneca]

Hello Ralf,

El 05/09/2014 18:26, "Ralf Friedl" <Ralf.Friedl at online.de> escribió:
>
> Xabier Oneca -- xOneca wrote:
>>
>> Hello again,
>>
>> 2014-09-05 18:19 GMT+02:00 Xabier Oneca  --  xOneca <xoneca at gmail.com>:
>>>
>>> Hello list,
>>>
>>> I want to highlight what GNU coreutils' help docs (info coreutils
>>> 'false invocation') says about false when invoked with --help:
>>>
>>>> Note that `false' (unlike all other programs documented herein)
>>>
>>> exits unsuccessfully, even when invoked with `--help' or `--version'.
>>>
>>> I think Busybox should do the same with the applet.
>>
>> And I want to add that --help will only be used ever in an interactive
>> shell by a person, so the return value may be dispensable. (i.e.
>> doesn't mind to the user how does --help return as soon as the help
>> text is printed in screen)
>
> Actually this is the argument to leave it as it is, because nobody cares
about the return value of "false --help".

What I was trying to say is that if a script appends --help to /bin/false
because of a poorly sanitized user input, it should still return 1. And
this change in behaviour wont not break any script nor user interaction
with the applet. (Maybe even fixes some scripts!)

>
> It might be nice if "false --help" would return false, but it would add
extra code to busybox for no real benefit.

How many bytes are in game here?

Cheers,

Xabier Oneca_,,_
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/busybox/attachments/20140905/02d41ddf/attachment-0001.html>