1.22.1: been hit by the zcat bug

Cristian Ionescu-Idbohrn cristian.ionescu-idbohrn at axis.com
Tue Oct 21 18:02:54 UTC 2014


On Tue, 21 Oct 2014, Mike Frysinger wrote:
> On 21 Oct 2014 18:41, Cristian Ionescu-Idbohrn wrote:
> > On Tue, 21 Oct 2014, Mike Frysinger wrote:
> > > On 20 Oct 2014 20:54, Cristian Ionescu-Idbohrn wrote:
> > > > That deserves a patch in http://busybox.net/downloads/fixes-1.22.1/,
> > > > IMO.  At least, commits:
> > > >
> > > > 	7c47b560a8fc97956dd8132bd7f1863d83c19866
> > > > 	b664f740d90880560ce46b11f766625341342e80
> > > > 	640ce3de07807133796bccd0bdfa146bbfc788c7
> > > >
> > > > may be relevantat.
> > >
> > > what exactly are you calling "the zcat bug" ?  seems to me only the
> > > first one should be backported.  `busybox zcat foo` failing when foo
> > > is not compressed matches standard `zcat` behavior. -mike
> >
> > Well, but it fails (but returns exit status success) even if the file
> > is compressed (ex. gzipped) but the fipped file extension isn't .gz.
> > It will procuce an exact copy of the original.
>
> yes, but that bug is only fixed by the first commit in your list:
> 	7c47b560a8fc97956dd8132bd7f1863d83c19866

Ok, if you say so.  But if I look at:

	$ git log --unified --reverse 1_22_1..master -- archival

I get the impression commit 7c47b560a8fc97956dd8132bd7f1863d83c19866,
by itself, isn't enough.  At least
b664f740d90880560ce46b11f766625341342e80 [libbb: open_zipped() should
not fail on non-compressed files] and
640ce3de07807133796bccd0bdfa146bbfc788c7 [zcat: complain if input is
not compressed] are also related.

> the others have no impact on that, hence my question as to what
> exactly are you looking to get fixed ?

Nothing needs to be fixed.  What I'm merryly suggesting is adding the
appropriate _existing_ patch(es) to
http://busybox.net/downloads/fixes-1.22.1/.  There may be a general
intrest in that.


Cheers,

-- 
Cristian


More information about the busybox mailing list