[PATCH] Use the standard libc types in fatattr

Denys Vlasenko vda.linux at googlemail.com
Fri Jul 4 14:25:11 UTC 2014


On Fri, Jul 4, 2014 at 4:06 PM, Laszlo Papp <lpapp at kde.org> wrote:
> On Fri, Jul 4, 2014 at 2:47 PM, Denys Vlasenko <vda.linux at googlemail.com>
> wrote:
>>
>> On Fri, Jul 4, 2014 at 3:26 PM, Laszlo Papp <lpapp at kde.org> wrote:
>> >> > -# define FAT_IOCTL_GET_ATTRIBUTES        _IOR('r', 0x10, __u32)
>> >> > -# define FAT_IOCTL_SET_ATTRIBUTES        _IOW('r', 0x11, __u32)
>> >> > +# define FAT_IOCTL_GET_ATTRIBUTES        _IOR('r', 0x10, uint32_t)
>> >> > +# define FAT_IOCTL_SET_ATTRIBUTES        _IOW('r', 0x11, uint32_t)
>> >> >  #endif
>> >> >
>> >> >  /* Currently supports only the FAT flags, not the NTFS ones.
>> >>
>> >>
>> >> Applied, thanks!
>> >>
>> >> (why kernel doesn't just use std types?...)
>> >
>> > What do you mean by "std types"?
>>
>> Like uint32_t
>
>
> As indicated before, it was only introduced in C99. The kernel project
> predates that for one.

I understand that.
It's 2014.
15 years to convert to (now-)standard type should be doable.


More information about the busybox mailing list