[PATCH] Remove 'BUG_const_mismatch', locally defined but not used.

Denys Vlasenko vda.linux at googlemail.com
Mon Feb 3 02:26:40 UTC 2014


On Sun, Feb 2, 2014 at 10:21 AM, Cristian Ionescu-Idbohrn
<cristian.ionescu-idbohrn at axis.com> wrote:
> coreutils/catv.c:32:15: warning: typedef 'BUG_const_mismatch' locally defined but not used [-Wunused-local-typedefs]
>   typedef char BUG_const_mismatch[
>                ^
>
> Signed-off-by: Cristian Ionescu-Idbohrn <cristian.ionescu-idbohrn at axis.com>
> ---
>  coreutils/catv.c | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/coreutils/catv.c b/coreutils/catv.c
> index e3499c5..3846aea 100644
> --- a/coreutils/catv.c
> +++ b/coreutils/catv.c
> @@ -29,10 +29,6 @@ int catv_main(int argc UNUSED_PARAM, char **argv)
>  #define CATV_OPT_e (1<<0)
>  #define CATV_OPT_t (1<<1)
>  #define CATV_OPT_v (1<<2)
> -       typedef char BUG_const_mismatch[
> -               CATV_OPT_e == VISIBLE_ENDLINE && CATV_OPT_t == VISIBLE_SHOW_TABS
> -               ? 1 : -1
> -       ];

This check is useful. I would like to retain it. How about moving it
to global scope?

#define CATV_OPT_e (1<<0)
#define CATV_OPT_t (1<<1)
#define CATV_OPT_v (1<<2)
struct BUG_const_mismatch {
        char BUG_const_mismatch[
                CATV_OPT_e == VISIBLE_ENDLINE && CATV_OPT_t == VISIBLE_SHOW_TABS
                ? 1 : -1
        ];
};

int catv_main(...)...


More information about the busybox mailing list